Add possibility to configure timeout for remote process #11271
+106
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Oct 1, 2024
droidmonkey
reviewed
Oct 1, 2024
| @@ -46,8 +46,10 @@ DatabaseSettingsWidgetRemote::DatabaseSettingsWidgetRemote(QWidget* parent) | |||
| connect(m_ui->nameLineEdit, &QLineEdit::textChanged, setModified); | |||
| connect(m_ui->downloadCommand, &QLineEdit::textChanged, setModified); | |||
| connect(m_ui->inputForDownload, &QPlainTextEdit::textChanged, setModified); | |||
| connect(m_ui->downloadTimeout, QOverload<int>::of(&QSpinBox::valueChanged), setModified); | |||
There was a problem hiding this comment.
Since you don't use the value from this signal you could just use textChanged to avoid the awkward QOverload
There was a problem hiding this comment.
I'm not sure why but the Ubuntu build does not agree
/opt/buildagent/work/c401303cba1b4098/src/gui/remote/DatabaseSettingsWidgetRemote.cpp: In constructor ‘DatabaseSettingsWidgetRemote::DatabaseSettingsWidgetRemote(QWidget*)’:
/opt/buildagent/work/c401303cba1b4098/src/gui/remote/DatabaseSettingsWidgetRemote.cpp:49:50: error: ‘textChanged’ is not a member of ‘QSpinBox’
49 | connect(m_ui->downloadTimeoutSec, &QSpinBox::textChanged, setModified);
| ^~~~~~~~~~~
/opt/buildagent/work/c401303cba1b4098/src/gui/remote/DatabaseSettingsWidgetRemote.cpp:52:48: error: ‘textChanged’ is not a member of ‘QSpinBox’
52 | connect(m_ui->uploadTimeoutSec, &QSpinBox::textChanged, setModified);
| ^~~~~~~~~~~
make[2]: *** [src/CMakeFiles/keepassxc_gui.dir/build.make:1254: src/CMakeFiles/keepassxc_gui.dir/gui/remote/DatabaseSettingsWidgetRemote.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:677: src/CMakeFiles/keepassxc_gui.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Process exited with code 2
- move calculations to GUI layer - add unit to downloadTimeout and uploadTimeout
t-h-e
force-pushed
the
feature/remote-timeout
branch
from
47d5529
to
32590c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #11234
Does NOT break existing configurations, as default values are used.
Screenshots
Testing strategy
Type of change