Dependancy Changes and Minor refactors #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependancy has not been mantained for over a year and is only used to calculate a mean
EvolveArt
approved these changes
Jan 18, 2024
Angel-Petrov
force-pushed
the
minor_refactors
branch
from
f0cac9f to
59b5b06
Compare
|
Closing as #40 also includes these changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changes I had made after taking a quick look at the codebase for anything simple to refactor/improve. The changes are listed below:
dotenvto the maintaineddotenvyfork to fix RUSTSEC-2021-0141: dotenv is Unmaintained #17statrsdue to not being mantained and also only being used to calculate a meanResultfrom theBenchmarkReport::to_jsonreturn type after changing the internals to guarantee it won't failDisplays destructureSelfbefore formatting so that they can be nicely embedded into the stringSysInfoformattingSysInfo'sDisplayimplementation showing frequency as3.GHzand changed it to show as3.50 GHzconcat!fromVERSION_STRINGPossible Additional Changes
Preferably,
BenchmarkReport::to_jsonshouldn't do any formatting ofSysInfo, if this exact structure isn't necessary we should swap it to just use theDisplayimplementation ofSysInfoviaSYSINFO.to_string()