Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the info endpoint by serializing the Info struct #28

Merged

Conversation

green-john
Copy link
Contributor

@green-john green-john commented Oct 20, 2024

Makes sure all structs are properly serialized in order to be returned as json. In addition, adds a test to verify the info endpoint works.

Before this change, the endpoint /v1/info/ wasn't working. It also fixes a couple of errors being thrown by the db on initial setup.

Fixes #29 and #30

Makes sure all structs are properly serialized in order to be returned as json. In addition, adds a test to verify the info endpoint works and fixes a couple of issues when inserting keysets in the database.
Andres Ruiz added 2 commits October 20, 2024 13:05
Copy link
Collaborator

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit 92757b8 into keep-starknet-strange:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: info endpoint is not working
2 participants