Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add TBTCSystem event log #740

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Add TBTCSystem event log #740

merged 4 commits into from
Nov 9, 2020

Conversation

lukasz-zimnoch
Copy link
Member

@lukasz-zimnoch lukasz-zimnoch commented Oct 23, 2020

Refs: keep-network/keep-ecdsa#574

Added a TBTCSystemEventLog allowing to access past events emitted by the TBTCSystem contract. This is a temporary workaround because contract bindings generated by the keep-common generator don't support this feature yet.

Added a `TBTCSystemFilterer` allowing
to access past events emitted by the
`TBTCSystem` contract. This is a temporary
workaround because contract bindings generated by
the `keep-common` generator don't
support this feature yet.
@lukasz-zimnoch lukasz-zimnoch changed the title Add TBTCSystem events filterer Add TBTCSystem event log Oct 26, 2020
@lukasz-zimnoch lukasz-zimnoch marked this pull request as ready for review October 27, 2020 13:37
@pdyraga
Copy link
Member

pdyraga commented Nov 6, 2020

Holding off with this one until discussion in a PR using this functionality is resolved.

@pdyraga
Copy link
Member

pdyraga commented Nov 9, 2020

Merging to do not block application-specific actions implementations in the client (keep-network/keep-ecdsa#585). This is not a final solution, and we'll have to update keep-common generators to generate the code from this PR, as we discussed here.

@pdyraga pdyraga merged commit 986e007 into master Nov 9, 2020
@pdyraga pdyraga deleted the tbtc-system-filterer branch November 9, 2020 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants