Remove support for Goerli testnet #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Goerli testnet will become deprecated with end of year 2023 and we've already migrated to Sepolia testnet where we could, we'll no longer need the Goerli-related code past that date.
deployment
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/7031088885 check. |
99 tasks
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/7031306134 check. |
As Wormhole does not support Sepolia-base L2 chains yet, we decided to still use Goerli for the cross-chainprojects (it's still live, despite EOL planned for 2023 EOY). So we're restoring the Goerli config in those projecst and we will remove it once Wormhole supports Sepolia L2s (or Goerli becomes unusable).
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/7477581060 check. |
Open
17 tasks
lukasz-zimnoch
previously approved these changes
Jan 29, 2024
lukasz-zimnoch
approved these changes
Jan 29, 2024
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/7695578503 check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Goerli testnet will become deprecated with end of year 2023 and we've already migrated to Sepolia testnet where we could, we'll no longer need the Goerli-related code past that date.
[UPDATE post-2023]: As Wormhole does not support Sepolia-base L2 chains yet, we decided to still use Goerli for the cross-chainp rojects (Goerli it's still live, despite EOL planned for 2023 EOY). So we're not removing Goerli config from the cross-chain projects - we will handle that in a later date (once Wormhole supports Sepolia L2s or Goerli becomes unusable).
Ref: threshold-network/solidity-contracts#150