-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase unit test coverage: unit tests for Deposit #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
increase-unit-test-coverage
branch
from
November 8, 2023 15:53
51649f9
to
94f52bb
Compare
tomaszslabon
force-pushed
the
increase-unit-test-coverage
branch
from
November 8, 2023 16:34
94f52bb
to
741ff8a
Compare
tomaszslabon
changed the title
Increase unit test coverage: Deposit.detectFunding
Increase unit test coverage: unit tests for Deposit
Nov 8, 2023
tomaszslabon
force-pushed
the
increase-unit-test-coverage
branch
from
November 8, 2023 17:01
2653e6f
to
20ad9a2
Compare
tomaszslabon
force-pushed
the
increase-unit-test-coverage
branch
from
November 13, 2023 11:43
f7d490b
to
27e9d3b
Compare
lukasz-zimnoch
previously approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one non-blocking comment that can be addressed in the follow-up PR.
lukasz-zimnoch
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #714.
This PR adds unit tests for the
Deposit
functions.