Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage: unit tests for Deposit #741

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Nov 8, 2023

#Refs: #714.
This PR adds unit tests for the Deposit functions.

@tomaszslabon tomaszslabon self-assigned this Nov 8, 2023
@tomaszslabon tomaszslabon added the 🔌 typescript TypeScript library label Nov 8, 2023
@tomaszslabon tomaszslabon force-pushed the increase-unit-test-coverage branch from 51649f9 to 94f52bb Compare November 8, 2023 15:53
@tomaszslabon tomaszslabon marked this pull request as ready for review November 8, 2023 15:53
@tomaszslabon tomaszslabon force-pushed the increase-unit-test-coverage branch from 94f52bb to 741ff8a Compare November 8, 2023 16:34
@tomaszslabon tomaszslabon changed the title Increase unit test coverage: Deposit.detectFunding Increase unit test coverage: unit tests for Deposit Nov 8, 2023
@tomaszslabon tomaszslabon force-pushed the increase-unit-test-coverage branch from 2653e6f to 20ad9a2 Compare November 8, 2023 17:01
@tomaszslabon tomaszslabon marked this pull request as draft November 8, 2023 17:05
@tomaszslabon tomaszslabon force-pushed the increase-unit-test-coverage branch from f7d490b to 27e9d3b Compare November 13, 2023 11:43
@tomaszslabon tomaszslabon marked this pull request as ready for review November 13, 2023 14:46
@lukasz-zimnoch lukasz-zimnoch added this to the typescript/v2.3.0 milestone Nov 14, 2023
lukasz-zimnoch
lukasz-zimnoch previously approved these changes Nov 14, 2023
Copy link
Member

@lukasz-zimnoch lukasz-zimnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one non-blocking comment that can be addressed in the follow-up PR.

typescript/test/services/deposits.test.ts Show resolved Hide resolved
@lukasz-zimnoch lukasz-zimnoch merged commit a9ed10d into main Nov 15, 2023
38 checks passed
@lukasz-zimnoch lukasz-zimnoch deleted the increase-unit-test-coverage branch November 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌 typescript TypeScript library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants