Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the npm-compile-publish job #710

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix the npm-compile-publish job #710

merged 1 commit into from
Oct 16, 2023

Conversation

lukasz-zimnoch
Copy link
Member

Refs: #697

The typescript library has been migrated from Node 14 to Node LTS (18) recently. We need to reflect that change in all CI jobs.

The typescript library has been migrated from Node 14 to Node LTS (18)
recently. We need to reflect that change in all CI jobs.
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It shouldn't disrupt any workflows on the token-dashboard side, because we specified the version of tbtc-v2.ts in package.json:

https://github.com/threshold-network/token-dashboard/blob/5875b44992cbe0c24439d227c6ca89e0568b11ca/package.json#L21

@michalsmiarowski michalsmiarowski merged commit 9f3c790 into main Oct 16, 2023
38 checks passed
@michalsmiarowski michalsmiarowski deleted the fix-npm-publish branch October 16, 2023 08:07
@lukasz-zimnoch lukasz-zimnoch added this to the typescript/v1.4.0 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants