This repository has been archived by the owner on May 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Filter past events related to tbtc specific actions #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpar
changed the title
Filter past SignatureSubmitted events
Filter past events related to tbtc specific actions
Nov 16, 2020
Two notes:
|
pdyraga
reviewed
Nov 16, 2020
pdyraga
reviewed
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four small comments and I am good assuming all jobs turn green. I'll leave the final review and testing to @lukasz-zimnoch.
Simple test to see if we can retrieve events and that it contains data:
For this event I had to do 2 things:
The logs below were added just locally for testing purposes just before this for loop
|
LGTM! I'll test these changes locally to make sure everything works. |
lukasz-zimnoch
previously approved these changes
Nov 17, 2020
Now we have functions generated by keep-common to get past events. Temp solution is replaced by the generated function now.
dimpar
force-pushed
the
filter-past-events
branch
from
November 18, 2020 09:34
86bb560
to
95c20b0
Compare
lukasz-zimnoch
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #574
Depends on: keep-network/keep-common#58
This PR replaces temp solutions for retrieving past events:
SignatureSubmitted
DepositRedemptionRequested
Past events retrieval can be done by calling generated functions
Past*
bykeep-common
project.