This repository has been archived by the owner on May 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Redemption flow actions #585
Merged
Merged
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
6d3e2da
Stub of the provide redemption signature action
lukasz-zimnoch 2fa23da
Provide redemption signature action
lukasz-zimnoch f84d2b0
Merge branch 'master' into redemption-actions
lukasz-zimnoch 43292b4
Simplify the iterator of past signature events
lukasz-zimnoch b13b76f
Remove the direct dependency on `gen/abi`
lukasz-zimnoch c120196
Add line break on start event casting
lukasz-zimnoch b5621ba
Implementation of the redemption proof action
lukasz-zimnoch 230da52
Merge branch 'master' into redemption-actions
lukasz-zimnoch 8bf4841
Set the right timeout for redemption proof action
lukasz-zimnoch db1536f
Move auxiliary types above `monitorAndAct`
lukasz-zimnoch 3396b77
Change alias of the `pkg/chain` package
lukasz-zimnoch 2307ccd
Update tbtc and use the `TBTCSystemEventLog`
lukasz-zimnoch 4482cbd
Rename `BondedECDSAKeepFilterer`
lukasz-zimnoch 513cc8f
Add TODO about chain reorgs
lukasz-zimnoch 01696f3
Change signature lookup during action execution
lukasz-zimnoch 6c03e6b
Optimize the start block when fetching past events
lukasz-zimnoch 1c9aa09
Happy path test for provide redemption signature
lukasz-zimnoch 1d4bcc1
Add GoSec exception for local chain randomness
lukasz-zimnoch 073fcf0
Add remaining tests for provide signature action
lukasz-zimnoch 5c55f3c
Happy path test for provide redemption proof
lukasz-zimnoch 46e1780
Fix failing unit tests
lukasz-zimnoch fa9e034
Add remaining tests for provide proof action
lukasz-zimnoch a9a5a8d
Tidy the go.sum file
lukasz-zimnoch 909ea90
Add comment to `BlockTimestamp` method
lukasz-zimnoch d507bf5
Add TODO about rate limiter
lukasz-zimnoch 10f673d
Move TBTC chain interface to `pkg/chain`
lukasz-zimnoch 2f77416
Fix import alias
lukasz-zimnoch 2f38d37
Add discussion link to the TODOs section
lukasz-zimnoch c3df0ec
Remove signature submitted event lookup loop
lukasz-zimnoch 5d17df5
Align mutex names in local chain implementations
lukasz-zimnoch d869e2d
Add ctx param to local chain constructor
lukasz-zimnoch 2dca954
Add test for local `SubmitSignature` method
lukasz-zimnoch 8cb25fd
Merge branch 'master' into redemption-actions
lukasz-zimnoch 9f67bfa
Add comment about `IncreaseRedemptionFee` call
lukasz-zimnoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to implement a solution in
keep-common
for a workaround in keep-network/tbtc#740 before merging this PR, right? Otherwise, we would end up with a situation wherekeep-ecdsa
master would not build againsttbtc
master.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we don't have to do anything in
keep-common
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need generators for eventlog? From the description of the referenced PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need the
abi
file which is already generated and tracked by the VCS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to implement a change to the generator in
keep-common
so that it generatesTBTCSystemEventLog
, correct?Let me put it this way:
We build tBTC go package from scratch:
pkg/chain/ethereum/gen
go generate ./...
thereThen we build
keep-ecdsa
:tbtc
go build
My understanding is that the compilation will fail because
TBTCSystemEventLog
will not be there.In other words, we are depending on a file that should be generated but it's not generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite. Eventually, we should extend the existing
keep-common
generator in that way it generates theFilter*
methods straight into theTBTCSystem
binding struct.TBTCSystemEventLog
is just a temporary workaround created manually without using the generator. It is also tracked by VCS similarly as the regular bindings. So, when we build tBTC package from scratch we shouldn't delete anything. We should only rungo generate ./...
to capture possible contract changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. So just to be clear - I am absolutely fine with merging this PR having
TBTCSystemEventLog
created manually just like now but I do not want to release a new version before we have this file generated or havingFilter*
methods generated intoTBTCSystem
struct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this discussion open until the proper solution is implemented. I do not want to block this PR, though.