-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heartbeats: Notify operator inactivity on failure #3800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 9, 2024 08:20
afb7436
to
b254be4
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 15, 2024 09:54
b254be4
to
6c57105
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 19, 2024 10:53
5c7b2ca
to
ca9ba4e
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 19, 2024 12:42
cb17b84
to
e2b4f34
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 23, 2024 14:34
a0157b2
to
147d82d
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
5 times, most recently
from
April 25, 2024 16:33
237268a
to
a288f9f
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
April 26, 2024 10:24
a288f9f
to
bd181a9
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 2, 2024 14:57
bbbfaf5
to
abad9ad
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 3, 2024 14:46
a4f4d9c
to
6c9fad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me 👌 Some last nitpick comments around naming:
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 13, 2024 14:00
b76f0fd
to
88f9dc2
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
4 times, most recently
from
May 13, 2024 16:44
70cba05
to
9372f63
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 13, 2024 16:49
9372f63
to
60da8cc
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 14, 2024 12:43
5434f36
to
82dc68a
Compare
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 14, 2024 17:32
6eaf756
to
64c02b4
Compare
lukasz-zimnoch
previously approved these changes
May 15, 2024
tomaszslabon
force-pushed
the
heartbeats-update
branch
from
May 15, 2024 12:46
c3664f9
to
e5d61e7
Compare
tomaszslabon
commented
May 15, 2024
lukasz-zimnoch
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #3796.
This PR enables notifying of operator inactivity failure after multiple failed heartbeats.
The inactivity notification is executed after three consecutive heartbeat failures.
A heartbeat is considered as failed if there was an error during message signing execution or the number of active signers was below a certain threshold.
The operator inactivity notification is performed by
inactivityClaimExecutor
and is similar to the DKG result submission process.