Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unmarshallers early during signing #3700

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Conversation

tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Aug 21, 2023

#Refs #3611.
This PR handles problems with unmarshallers not found errors during signing:

eep-libp2p	libp2p/channel.go:286	couldn't find unmarshaler for type [protocol_announcer/announcement_message]
keep-libp2p	libp2p/channel.go:286	couldn't find unmarshaler for type [tbtc/signing_done_message]

The solution is is to register the marshaller for those messages early, before the signing process begins.

@tomaszslabon tomaszslabon marked this pull request as ready for review August 21, 2023 12:48
@tomaszslabon tomaszslabon requested review from lukasz-zimnoch and pdyraga and removed request for lukasz-zimnoch August 21, 2023 12:49
@dimpar
Copy link
Contributor

dimpar commented Sep 5, 2023

I run the clients just fine, but I don't think I can hit the early signing stage before the sweep proposal on my local. System tests passed. Code looks good to me as well. Leaving the final approval to @lukasz-zimnoch or @pdyraga since they are more familiar with the flow.

@dimpar
Copy link
Contributor

dimpar commented Sep 7, 2023

It was decided that the full flow will be validated on the testnet with the keep clients that have this change. Otherwise, it is very tricky to hit the early signing stage before the sweep on the local env.

@dimpar dimpar merged commit 7157a33 into main Sep 7, 2023
29 checks passed
@dimpar dimpar deleted the unmarshaller-not-found-fix branch September 7, 2023 07:49
@lukasz-zimnoch lukasz-zimnoch added this to the v2.0.0-m5 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants