Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print deposit type #3691

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Print deposit type #3691

merged 3 commits into from
Sep 1, 2023

Conversation

tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Jul 20, 2023 •
edited
Loading

#Refs: #3584.
This PR adds printing of deposit type when listing deposits.
Example:

 index                                     wallet  type value (BTC)                                                        deposit key                                                        revealed deposit data confirmations swept
     0 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     0.01000 0xdfc777272c584c79cdbfc60c59bc70f995b69abdebc4eeed2d89c4de7af8c722  434449cbe4bf0113891709b333483be49b03a21cd13f76518855d3769f8ff4ba:0:16632018         22927  true
     1 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     3.08958 0xb0345aa6e96f1f36b663d06e0f1ca5b7776d5d5815c3f9c600a4c7376abdf741  b2d3d44e29869bbda13a87b0fd05b911d5ad9a1b603aa9bf19d6683a7e2897fc:0:16632106         22926  true

@tomaszslabon tomaszslabon self-assigned this Jul 20, 2023
@dimpar
Copy link
Contributor

dimpar commented Aug 30, 2023 •
edited
Loading

KEEP_ETHEREUM_PASSWORD=<password> ./keep-client maintainer-cli list-deposits --wallet 0b462faec647aaa958eb1bc39f5febb6f340aa99 --config [path]/configs/maintainer.toml

Looks good to me. Leaving it to @pdyraga / @lukasz-zimnoch for the final approval and merge.

     0 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     0.01000 0xdfc777272c584c79cdbfc60c59bc70f995b69abdebc4eeed2d89c4de7af8c722  434449cbe4bf0113891709b333483be49b03a21cd13f76518855d3769f8ff4ba:0:16632018         28854  true
     1 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     3.08958 0xb0345aa6e96f1f36b663d06e0f1ca5b7776d5d5815c3f9c600a4c7376abdf741  b2d3d44e29869bbda13a87b0fd05b911d5ad9a1b603aa9bf19d6683a7e2897fc:0:16632106         28853  true
     2 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     5.00000 0xeeb8efdab2633973d18bfa172acd1d28c5fab2fb900cd71bd3297d83591faaf9  c97e2955770d85a8b5cdef7e731d404b8f6f6d9cf692239baa20b5a6241aa85f:0:16672942         27909  true
     3 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     5.00000 0x60f9110e2207f1aabf57c4fadd506de2dcc308ec3491d9038d3404586ec19127  51be1691a518d2416a404542aba818d556dddab096dd7172aed25ce6a3ddc74c:0:16674254         27873  true
     4 0x1ba8b9d7d9ebe90c932bf91df58db67e87f686de P2WSH     0.01030 0x88416cc590b1faeca55142df2f0538d46b19aab19c55d8216bb2a7ad6d6cd729  784622a1adc067e34a2f0fb106a3423c25af0ae8b7d4f9c092aed66f35de66a0:0:16690328         27525  true

@dimpar dimpar merged commit bf6900e into main Sep 1, 2023
29 checks passed
@dimpar dimpar deleted the print-deposit-type branch September 1, 2023 11:54
@dimpar dimpar added this to the v2.0.0-m5 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpar dimpar dimpar approved these changes

@lukasz-zimnoch lukasz-zimnoch Awaiting requested review from lukasz-zimnoch

@pdyraga pdyraga Awaiting requested review from pdyraga

Assignees

@tomaszslabon tomaszslabon

Labels
📟 client
Projects
None yet
Milestone
v2.0.0-m5
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaszslabon @dimpar