Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce optional command generation #53

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Introduce optional command generation #53

merged 1 commit into from
Oct 22, 2020

Conversation

lukasz-zimnoch
Copy link
Member

@lukasz-zimnoch lukasz-zimnoch commented Oct 20, 2020

Refs: keep-network/keep-ecdsa#574

Added the possibility to omit the command output file argument and make the generation of the command files optional.

Added the possibility to omit the command
output file argument and make generation
of the command files optional.
@pdyraga
Copy link
Member

pdyraga commented Oct 22, 2020

Double-checked by pointing keep-ecdsa dependency to keep-common at 19c123c and generating contracts. No problems observed.

@pdyraga pdyraga merged commit ea88903 into master Oct 22, 2020
@pdyraga pdyraga deleted the optional-commands branch October 22, 2020 10:33
@pdyraga
Copy link
Member

pdyraga commented Oct 22, 2020

More context on why we are doing it. In keep-network/tbtc#739 we want to generate Go bindings for tbtc contracts but generating commands requires adding a dependency from tbtc to keep-core. We want to avoid that and given that tbtc.js provides a CLI to interact with tbtc contracts, we decided to making command generation optional.

@pdyraga pdyraga added this to the v1.3.0 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants