Trim underscore prefix while generating event params #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underscore prefixes should be trimmed while capitalizing and uncapitalizing the first letter of the event params. This change is required because abigen does the same while generating the underlying contract binding so names must be aligned to avoid compilation errors.
Can you please provide a link where it's done by |
Here is a PR: ethereum/go-ethereum#15766 |
pdyraga
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/keep-ecdsa#574
Underscore prefixes should be trimmed while capitalizing and uncapitalizing the first letter of the event params. This change
is required because
abigendoes the same while generating the underlying contract binding so names must be aligned toavoid compilation errors.