Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build against musl #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build against musl #62

wants to merge 1 commit into from

Conversation

Mic92
Copy link

@Mic92 Mic92 commented May 6, 2020

No description provided.

ninewise
ninewise reviewed May 11, 2020
View reviewed changes
Copy link

@ninewise ninewise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe align the variable names again, to keep styling consistent. (Side note: the jshon master branch hasn't seen activity for some time, don't be surprised when the PR doesn't get merged.)

@Mic92
Copy link
Author

Mic92 commented May 11, 2020

Fixed. Is there a more active fork of it?

@ninewise
Copy link

Not as far as I know. I don't really use jshon any more, but should you (or anyone) start one, I'd transfer my patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninewise ninewise ninewise left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @ninewise