Update Makefile to use $PREFIX #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard prefix is /usr/local. This makes it easier for me to install it (I always override this variable for my home folder) and is also more standard. See https://www.gnu.org/prep/standards/standards.html#Directory-Variables
|
I just made the exact same patch manually. This checks out. |
embray
reviewed
May 9, 2018
| @@ -4,12 +4,13 @@ CFLAGS := -std=c99 -Wall -pedantic -Wextra -Werror ${CFLAGS} | |||
| LDLIBS = -ljansson | |||
| INSTALL=install | |||
| DESTDIR?=/ | |||
There was a problem hiding this comment.
While at it, it might be good to make DESTDIR default to empty. Otherwise you wind up with paths beginning with // which at best is ugly, and at worst breaks on some platforms (Cygwin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard prefix is /usr/local. This makes it easier for me to install it (I always override this variable for my home folder) and is also more standard.
See https://www.gnu.org/prep/standards/standards.html#Directory-Variables