Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update robots.txt for 0.19.6 #3885

Merged
merged 3 commits into from
May 23, 2024
Merged

Update robots.txt for 0.19.6 #3885

merged 3 commits into from
May 23, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented May 22, 2024

Description

Check if we have new datasets release?

Development notes

  • Add new rules Allow: */sitemap.xml
  • Change / to * because we have version like 0.19.1 and 19.1.post1 now
  • Maybe we need to kedro-datasets.3.0.0* to something else, I am not sure what's the new version.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok Lam Chan <[email protected]>
@noklam noklam requested a review from ankatiyar May 22, 2024 11:19
Signed-off-by: Nok Lam Chan <[email protected]>
@noklam noklam marked this pull request as ready for review May 22, 2024 15:56
Allow: /projects/kedro-viz/en/stable/
Allow: /projects/kedro-datasets/en/kedro-datasets-3.0.0/
Allow: /projects/kedro-datasets/en/kedro-datasets-3.0.0*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward we have to find a way to stop doing this, keeping a list of releases like this is error prone #3741

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hope this is the right one 🙏🏼

@astrojuanlu astrojuanlu merged commit 545cab7 into main May 23, 2024
10 checks passed
@astrojuanlu astrojuanlu deleted the noklam/robots-txt branch May 23, 2024 08:00
This was referenced May 23, 2024
@noklam noklam linked an issue May 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sitemap indexing
3 participants