-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default props from functional components #1906
Conversation
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left one comment.
I did a project-wide find for defaultProps
and found one left:
kedro-viz/tools/test-lib/react-app/app.js
Line 80 in 63cfeaa
App.defaultProps = { |
But it's in the /tools/test-lib
directory so I don't think it matters too much.
Signed-off-by: huongg <[email protected]>
yeah I didn't remove it cause it seems like there was no error, but maybe best to remove it too, to be consistent with the rest |
Signed-off-by: huongg <[email protected]>
…fault-props Signed-off-by: huongg <[email protected]>
Description
Fixes #1905
Development notes
I've removed the defaults props from our Functional components, set them directly in the props values instead
QA notes
All the tests have passed and everything seems to work fine form my side
Checklist
RELEASE.md
file