Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for schema change in strawberry-graphql JSON scalar #1903

Merged
merged 8 commits into from
May 15, 2024
Merged

Fix for schema change in strawberry-graphql JSON scalar #1903

merged 8 commits into from
May 15, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented May 14, 2024 •
edited
Loading

Description

Development notes

  • Updated GraphQL schema JSON scalar specifiedBy location to fix build

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix for strawberry graphQL schema change Fix for Strawberry GraphQL schema change May 14, 2024
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix for Strawberry GraphQL schema change Fix for schema change in strawberry-graphql JSON scalar May 15, 2024
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review May 15, 2024 02:26
@ravi-kumar-pilla ravi-kumar-pilla requested review from Huongg and removed request for astrojuanlu May 15, 2024 02:27
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request May 15, 2024
Merged
5 tasks
Huongg
Huongg approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ravi-kumar-pilla

@ravi-kumar-pilla ravi-kumar-pilla merged commit aabb3a2 into main May 15, 2024
31 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/strawberry-update branch May 15, 2024 14:39
This was referenced May 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@Huongg Huongg Huongg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-kumar-pilla @Huongg @rashidakanchwala