Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable/disable preview for all the datasets when publishing Kedro-Viz from UI #1895

Merged
merged 52 commits into from
Jun 12, 2024
Merged

Enable/disable preview for all the datasets when publishing Kedro-Viz from UI #1895

merged 52 commits into from
Jun 12, 2024

Commits on May 3, 2024

  1. Add options for cli common with disable preview of datasets 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    74e0371 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. New approach for disable preview 

    Signed-off-by: <>
    @jitu5
    jitu5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5398a11 View commit details
    Browse the repository at this point in the history

  2. Disable preview for cli and lint fix 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4da365f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. deploy api with preview 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9f2afa2 View commit details
    Browse the repository at this point in the history

  2. Removing UI changes 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    35f1436 View commit details
    Browse the repository at this point in the history

  3. Removing UI changes 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    85e1a2d View commit details
    Browse the repository at this point in the history

  4. Disable preview from UI 

    Signed-off-by: <>
    @jitu5
    jitu5 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f8f96cf View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Code review suggestions 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    dc51032 View commit details
    Browse the repository at this point in the history

  2. temp code removed 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f3b8007 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. refactor disable preview cli 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d8ef988 View commit details
    Browse the repository at this point in the history

  2. fix lint 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3377832 View commit details
    Browse the repository at this point in the history

  3. fix lint 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7a31729 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fe… 

    …ature/disable-preview

Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    028a7f3 View commit details
    Browse the repository at this point in the history

  2. testing 1 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    78f44bb View commit details
    Browse the repository at this point in the history

  3. change help text 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    663924c View commit details
    Browse the repository at this point in the history

  4. change help text 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    defbf66 View commit details
    Browse the repository at this point in the history

  5. update tests 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9195150 View commit details
    Browse the repository at this point in the history

  6. format help text 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c4c7375 View commit details
    Browse the repository at this point in the history

  7. change default preview for run 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6eaaaeb View commit details
    Browse the repository at this point in the history

  8. update release note 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8372ec3 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. merged cli version to avoid test failures 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c854392 View commit details
    Browse the repository at this point in the history

  2. address vale suggestion 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2f67e78 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/disable-preview' of https://github.com/kedro-or… 

    …g/kedro-viz into feature/disable-preview-ui

Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ffdce46 View commit details
    Browse the repository at this point in the history

  4. fix lint 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e465101 View commit details
    Browse the repository at this point in the history

  5. fix pytests and linter 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    12eabd1 View commit details
    Browse the repository at this point in the history

  6. adjust file permission 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    57b68b3 View commit details
    Browse the repository at this point in the history

  7. merged new changes 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ec92a7f View commit details
    Browse the repository at this point in the history

  8. update tests 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    50ef2a4 View commit details
    Browse the repository at this point in the history

  9. update release note 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e523f23 View commit details
    Browse the repository at this point in the history

  10. update release note 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4f5c446 View commit details
    Browse the repository at this point in the history

  11. resolve conflicts 

    Signed-off-by: ravi-kumar-pilla <[email protected]>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a4b564b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. --include-preview flag added for CLI 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c815a9b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 20, 2024
    Configuration menu
    Copy the full SHA
    5a43fda View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 21, 2024
    Configuration menu
    Copy the full SHA
    0998f7a View commit details
    Browse the repository at this point in the history

  2. are_datasets_previewable renamed to is_all_previews_enabled 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d06f36e View commit details
    Browse the repository at this point in the history

  3. lint fix 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    73b1944 View commit details
    Browse the repository at this point in the history

  4. are_datasets_previewable renamed to is_all_previews_enabled 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2294cc6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/disable-preview' into feature/disable-preview-ui 

    Signed-off-by: <>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    148e92d View commit details
    Browse the repository at this point in the history

  6. type ignore add for TRANSCODING_SEPARATOR 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    94e3501 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/disable-preview' into feature/disable-preview-ui 

    Signed-off-by: <>
    @jitu5
    jitu5 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    036c89e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 22, 2024
    Configuration menu
    Copy the full SHA
    46dbf28 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 29, 2024
    Configuration menu
    Copy the full SHA
    20bbe47 View commit details
    Browse the repository at this point in the history

  2. File permissions updated 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6f088b5 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    b80c799 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'main' into feature/disable-preview

    @jitu5
    jitu5 authored May 31, 2024
    Configuration menu
    Copy the full SHA
    788a491 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/disable-preview 

    # Conflicts:
#	package/kedro_viz/models/flowchart.py
    @jitu5
    jitu5 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    57aec4e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/disable-preview' into feature/disable-preview-ui 

    Signed-off-by: <>
    @jitu5
    jitu5 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2f54122 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/disable-preview-ui 

    Signed-off-by: <>

# Conflicts:
#	RELEASE.md
    @jitu5
    jitu5 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    80ad5e7 View commit details
    Browse the repository at this point in the history

  5. fix 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c706625 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into feature/disable-preview-ui 

    Signed-off-by: <>
    @jitu5
    jitu5 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    0ac6b1b View commit details
    Browse the repository at this point in the history

  2. All dataset preview toggle works with deploy api 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9d50abb View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. CLI flag renamed to --include-previews 

    Signed-off-by: Jitendra Gundaniya <[email protected]>
    @jitu5
    jitu5 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4a82230 View commit details
    Browse the repository at this point in the history