Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AzureEventGrid Infra #146

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Conversation

SpiritZhou
Copy link
Contributor

Add AzureEventGrid Infra for cloudevent-azureventgrid-test

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to # kedacore/keda#5606

Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner March 15, 2024 08:49
@JorTurFer
Copy link
Member

Please, execute terraform fmt --recursive, commit & push the changes.

@JorTurFer
Copy link
Member

I have no idea about the required resources, could you confirm that these are correct?

  • A ServiceBus topic in the main ServiceBus: keda-e2e-receive-event-grid-topic
  • A ServiceBus topic in the alternative ServiceBus (we use it for podidentity impersonation test): keda-e2e-receive-event-grid-topic
  • A new ServiceBus namespace: keda-e2e-servicebus-namespace-event-grid including
    • Azure Service Bus Data Owner role asignment
    • An authorizartion rule
    • A topic keda-e2e-receive-event-grid-topic
  • An EventGrid subscription
  • An EventGrid topic

Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Copy link
Contributor Author

I have no idea about the required resources, could you confirm that these are correct?

  • A ServiceBus topic in the main ServiceBus: keda-e2e-receive-event-grid-topic

  • A ServiceBus topic in the alternative ServiceBus (we use it for podidentity impersonation test): keda-e2e-receive-event-grid-topic

  • A new ServiceBus namespace: keda-e2e-servicebus-namespace-event-grid including

    • Azure Service Bus Data Owner role asignment
    • An authorizartion rule
    • A topic keda-e2e-receive-event-grid-topic
  • An EventGrid subscription

  • An EventGrid topic

Yes. What I want is creating a new event grid and a serviceBus topic to receive events.

Signed-off-by: SpiritZhou <[email protected]>
@JorTurFer
Copy link
Member

Yes. What I want is creating a new event grid and a serviceBus topic to receive events.

Okey! In the future, I think that we can include a flag to deploy the topic or support providing the topics as input, but as topics don't have cost IIRC, we can continue with the PR as it is

@JorTurFer JorTurFer merged commit 35c9c9f into kedacore:main Mar 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants