Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Query at the Elasticsearch scaler #6217

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Support Query at the Elasticsearch scaler #6217

merged 5 commits into from
Oct 21, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 3, 2024 •
edited
Loading

  • Adding the query parameter to pass an Elasticsearch query.

Checklist

Fixes #6216
Docs: kedacore/keda-docs#1480

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 3, 2024 11:38
@rickbrouwer rickbrouwer marked this pull request as draft October 3, 2024 11:38
@rickbrouwer rickbrouwer force-pushed the elastic-query branch 3 times, most recently from 6c76a61 to d572b53 Compare October 3, 2024 12:21
@rickbrouwer rickbrouwer marked this pull request as ready for review October 3, 2024 12:41
@wozniakjan
Copy link
Member

wozniakjan commented Oct 15, 2024 •
edited by github-actions bot
Loading

/run-e2e elastic
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

JorTurFer
JorTurFer reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover this with an e2e tests? Does it make sense?

@rickbrouwer rickbrouwer force-pushed the elastic-query branch 6 times, most recently from af86411 to 87b133c Compare October 19, 2024 16:00
@rickbrouwer
Copy link
Contributor Author

Could we cover this with an e2e tests? Does it make sense?

Yeah, that make sense. I added a test case to the e2e test.

@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e elastic
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) October 21, 2024 07:57
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e elastic
Update: You can check the progress here

wozniakjan
wozniakjan reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really great, just one minor nit regarding sleep in test that I would like to try to change if possible

tests/scalers/elasticsearch/elasticsearch_test.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 21, 2024 10:17

Head branch was pushed to by a user without write access

@rickbrouwer rickbrouwer force-pushed the elastic-query branch 4 times, most recently from 2abbe64 to f3cb3d0 Compare October 21, 2024 10:38
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e elastic
Update: You can check the progress here

@rickbrouwer rickbrouwer force-pushed the elastic-query branch 2 times, most recently from c756587 to 858c8a3 Compare October 21, 2024 11:09
@wozniakjan wozniakjan enabled auto-merge (squash) October 21, 2024 11:19
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e elastic
Update: You can check the progress here

@wozniakjan wozniakjan merged commit a390a91 into kedacore:main Oct 21, 2024
18 checks passed
@rickbrouwer rickbrouwer deleted the elastic-query branch October 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 'query' at the Elasticsearch scaler
3 participants
@rickbrouwer @wozniakjan @JorTurFer