Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Selenium Grid scaler #6169

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor Selenium Grid scaler #6169

wants to merge 7 commits into from
+1,853 −562

Conversation

VietND96
Copy link

@VietND96 VietND96 commented Sep 17, 2024 •
edited
Loading

Provide a description of what has been changed

  1. Selenium Grid Scaler: Improve logic based on node stereotypes, node sessions and queue requests capabilities (#6080)
  • Enhanced KEDA scaler behavior, addressing:
    • Node with different platformName scaling: Fixed incorrect scaling behavior when both Linux and Windows node stereotypes are present (#1925).
    • Excessive autoscaling: Resolved over-scaling of browser nodes (#2160).
  1. Added one more parameter nodeMaxSessions (default is 1), to configure the scaler to be aligned with option --max-sessions (env var SE_NODE_MAX_SESSIONS) in the Node. It helps the calculation be better.
  2. Selenium Grid Scaler: Support for Username and Password Authentication of Grid GraphQL endpoint (#6144)
  3. Update all unit tests accordingly to the new GraphQL response.

Checklist

Fixes #6144 Fixes #6080

Relates to SeleniumHQ/docker-selenium#2160, SeleniumHQ/docker-selenium#1925, #6047

@VietND96 VietND96 requested a review from a team as a code owner September 17, 2024 01:14
@VietND96 VietND96 mentioned this pull request Sep 17, 2024
Closed
@Doofus100500 Doofus100500 mentioned this pull request Sep 17, 2024
Closed
7 tasks
@VietND96 VietND96 mentioned this pull request Sep 17, 2024
Open
1 task
@SpiritZhou
Copy link
Contributor

SpiritZhou commented Sep 18, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

This was referenced Sep 18, 2024
Merged
Merged
@farioas farioas mentioned this pull request Sep 23, 2024
Merged
8 tasks
@VietND96
Copy link
Author

VietND96 commented Oct 2, 2024

Noted that we also set up some e2e tests in the downstream repo https://github.com/SeleniumHQ/docker-selenium/tree/trunk/.keda for the evaluation and feedback from community

@zroubalik
Copy link
Member

zroubalik commented Oct 2, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

zroubalik
zroubalik approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is really great, thanks for the contribution!

@VietND96 VietND96 force-pushed the main branch 10 times, most recently from 4e46487 to 86e662c Compare October 7, 2024 03:17
@VietND96
Copy link
Author

VietND96 commented Oct 7, 2024

/run-e2e selenium

@VietND96
Copy link
Author

VietND96 commented Oct 9, 2024

@SpiritZhou, @zroubalik, could you please help trigger one more command for /run-e2e selenium ?

@zroubalik
Copy link
Member

zroubalik commented Oct 9, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@VietND96
Copy link
Author

VietND96 commented Oct 9, 2024

Not sure why the svc address could not reach in workflow

04-0-09T5:***8:45Z ERROR scale_handler error getting scale decision ***"scaledObject.Namespace": "selenium-test-ns", "scaledObject.Name": "firefox-selenium-test-so", "scaler": "seleniumGridScaler", "error": "error requesting selenium grid endpoint: Post "***selenium-hub.selenium-test-ns:4444/graphql": dial tcp 0.0.5.6:4444: connect: connection refused"

In local, I could see it passed always

PASS
ok command-line-arguments 49.126s
##############################################
##############################################
EXECUTION SUMMARY
##############################################
##############################################
Passed tests:
Execution of tests/scalers/selenium/selenium_test.go, has passed after "one" attempts

@VietND96
Refactor Selenium Grid scaler
28a06a7 
Signed-off-by: Viet Nguyen Duc <[email protected]>
@JorTurFer JorTurFer mentioned this pull request Oct 16, 2024
Merged
1 task
@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@VietND96
Add unit tests from other PRs
c4c74f7 
Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Copy link
Author

@JorTurFer, UTs and e2e passed. I also updated docs aligned with this.

@JorTurFer
Copy link
Member

JorTurFer commented Oct 17, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@VietND96
Merge branch 'main' into main
f583457 
Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Copy link
Author

@JorTurFer, fixed conflicted from latest main branch

@zroubalik
Copy link
Member

zroubalik commented Oct 23, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) October 23, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@VietND96 @SpiritZhou @zroubalik @JorTurFer