Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS region to the AWS Config Cache key #6134

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add AWS region to the AWS Config Cache key #6134

wants to merge 5 commits into from
+45 −21

Conversation

maxbog
Copy link

@maxbog maxbog commented Sep 4, 2024 •
edited
Loading

The PR adds the AWS region to the key used by the AWS config cache

Checklist

Fixes #6128

@maxbog maxbog requested a review from a team as a code owner September 4, 2024 09:37
@maxbog maxbog force-pushed the region_in_aws_config_cache branch 4 times, most recently from e025102 to a67350c Compare September 4, 2024 13:49
zroubalik
zroubalik reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is broken

@maxbog
add CHANGELOG entry
baa3cc1 
Signed-off-by: Maksymilian Boguń <[email protected]>
@maxbog
Copy link
Author

maxbog commented Sep 18, 2024

@zroubalik I fixed the build

@zroubalik
Copy link
Member

zroubalik commented Sep 18, 2024 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Sep 19, 2024 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@maxbog
Copy link
Author

maxbog commented Sep 24, 2024

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

@zroubalik
Copy link
Member

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

yeah, issue on our side, will rerun once it is fixed

@ndlanier
Copy link

ndlanier commented Oct 4, 2024

@zroubalik any updates on the e2e testing?

@JorTurFer
Copy link
Member

JorTurFer commented Oct 6, 2024 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@maxbog
Copy link
Author

maxbog commented Oct 9, 2024

@JorTurFer I rebased the PR
Now the tests failed, but it looks like some random crash, can you please rerun the failing job and the e2e tests?

@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @kedacore/keda-core-contributors

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2024 18:00
@ndlanier
Copy link

ndlanier commented Oct 28, 2024 •
edited
Loading

Any insight into why it paniced/failed on the amd64 validation?

@ndlanier
Copy link

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

@JorTurFer
Copy link
Member

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

I've triggered it again because probably it was a transient error

@JorTurFer
Copy link
Member

@zroubalik @wozniakjan PTAL

@JorTurFer JorTurFer enabled auto-merge (squash) October 31, 2024 00:47
@JorTurFer
Copy link
Member

JorTurFer commented Nov 2, 2024 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS credentials cache key needs to include the region
4 participants
@maxbog @zroubalik @ndlanier @JorTurFer