Add generateEmbeddedObjectMeta flag when generating crd #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
tomkerkhove
reviewed
Jul 3, 2024
Signed-off-by: SpiritZhou <[email protected]>
|
/run-e2e internal |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
JorTurFer
reviewed
Sep 29, 2024
| @@ -60,6 +60,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio | |||
|
|
|||
| - TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX)) | |||
| - **General**: Add --ca-dir flag to KEDA operator to specify directories with CA certificates for scalers to authenticate TLS connections (defaults to /custom/ca) ([#5860](https://github.com/kedacore/keda/issues/5860)) | |||
| - **General**: Add the generateEmbeddedObjectMeta flag to generate meta properties of JobTargetRef in ScaledJob ([#5908](https://github.com/kedacore/keda/issues/5908)) | |||
There was a problem hiding this comment.
This will need to be moved to the current version
stale
bot
removed
the
stale
|
LGTM and it's a nice fix indeed! |
Signed-off-by: SpiritZhou <[email protected]>
JorTurFer
approved these changes
Nov 3, 2024
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generateEmbeddedObjectMeta flag when generating crd
Checklist
Relates to # #5908