Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics Adapter: remove deprecated Prom Metrics and non-gRPC code #4479

Merged
merged 1 commit into from
May 18, 2023
Merged

Metrics Adapter: remove deprecated Prom Metrics and non-gRPC code #4479

merged 1 commit into from
May 18, 2023

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Apr 26, 2023 •
edited
Loading

Provide a description of what has been changed

Checklist

Fixes #3930

@zroubalik zroubalik requested a review from a team as a code owner April 26, 2023 17:48
@zroubalik zroubalik marked this pull request as draft April 26, 2023 17:48
@zroubalik zroubalik force-pushed the remDep branch 2 times, most recently from 7cae6fe to 80c1892 Compare April 26, 2023 17:56
@zroubalik zroubalik changed the title Metrics Adapter: remove deprecated Prom Metrics and cleanup Metrics Adapter: remove deprecated Prom Metrics and non-gRPC code Apr 26, 2023
@zroubalik zroubalik force-pushed the remDep branch 2 times, most recently from 8bde4c8 to 184d692 Compare April 26, 2023 18:19
@kedacore kedacore deleted a comment from zroubalik Apr 26, 2023
@kedacore kedacore deleted a comment from zroubalik Apr 26, 2023
@zroubalik
Copy link
Member Author

zroubalik commented Apr 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Apr 27, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e prometheus_metrics
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented May 18, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik marked this pull request as ready for review May 18, 2023 11:22
@zroubalik
Copy link
Member Author

zroubalik commented May 18, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) May 18, 2023 11:43
@zroubalik zroubalik merged commit 4ae8975 into kedacore:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated code for exposing Prometheus Metrics from Metrics Server
2 participants
@zroubalik @JorTurFer