Remove unnecessary validate in kubernetes workload and cpu mem (#6286)

* Remove validate cpu memory scaler Signed-off-by: rickbrouwer <[email protected]> * Remove validate kubernetes workload Signed-off-by: rickbrouwer <[email protected]> --------- Signed-off-by: rickbrouwer <[email protected]>
kedacore · Nov 2, 2024 · 5062262 · 5062262
1 parent 4376101
commit 5062262
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/pkg/scalers/cpu_memory_scaler.go b/pkg/scalers/cpu_memory_scaler.go
@@ -29,10 +29,6 @@ type cpuMemoryMetadata struct {
 	MetricType         v2.MetricTargetType
 }
 
-func (m *cpuMemoryMetadata) Validate() error {
-	return nil
-}
-
 // NewCPUMemoryScaler creates a new cpuMemoryScaler
 func NewCPUMemoryScaler(resourceName v1.ResourceName, config *scalersconfig.ScalerConfig) (Scaler, error) {
 	logger := InitializeLogger(config, "cpu_memory_scaler")
@@ -42,13 +38,6 @@ func NewCPUMemoryScaler(resourceName v1.ResourceName, config *scalersconfig.Scal
 		return nil, fmt.Errorf("error parsing %s metadata: %w", resourceName, err)
 	}
 
-	if err := meta.Validate(); err != nil {
-		if meta.MetricType == "" {
-			return nil, fmt.Errorf("metricType is required")
-		}
-		return nil, fmt.Errorf("validation error: %w", err)
-	}
-
 	return &cpuMemoryScaler{
 		metadata:     meta,
 		resourceName: resourceName,

diff --git a/pkg/scalers/kubernetes_workload_scaler.go b/pkg/scalers/kubernetes_workload_scaler.go
@@ -87,10 +87,6 @@ func parseKubernetesWorkloadMetadata(config *scalersconfig.ScalerConfig) (kubern
 	}
 	meta.podSelector = selector
 
-	if err := meta.Validate(); err != nil {
-		return meta, err
-	}
-
 	return meta, nil
 }