-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PredictKube Scaler docs #617
Conversation
❌ Deploy Preview for keda failed. 🔨 Explore the source changes: 35c76b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/61f153d646e9cd0008cd5a39 |
6d1b4e1
to
9007004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like PredictKube is a service people need an API key for. I think it would be good if:
- There is an introduction added before
Trigger Specification
clarifying that PredictKube is a service - Provide transparency on the data usage that is being sent to PredictKube. This can be as simple as adding a link to a privacy/legal page on your official docs but it should provide transparency if customer metrics are used to train the model as well
Thank you!
Thanks for this important point, Tom! We're currently working on our full policy to publish it in the nearest future. |
Thank you! But I'd say this is a mandatory thing to have before we can merge this feature as it is pretty important for end-users to understand. |
a7b4fb3
to
f3bd71c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but waiting for feature to be merged.
56fa102
to
041229d
Compare
c947dda
to
a21e696
Compare
@daniel-yavorovich looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go |
c16c7a4
to
952ba17
Compare
done, thank you |
@daniel-yavorovich I can see 32 commits in this PR and majority of them non related to this PR |
9f07af8
to
df77267
Compare
Signed-off-by: Daniel Yavorovych <[email protected]>
df77267
to
35c76b6
Compare
everything should be fine now |
This PR adds documentation for a new PredictKube Scaler.
Checklist
Relates to kedacore/keda#2418 & kedacore/keda#2458