Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PredictKube Scaler docs #617

Merged
merged 1 commit into from
Jan 26, 2022
Merged

add PredictKube Scaler docs #617

merged 1 commit into from
Jan 26, 2022

Conversation

daniel-yavorovich
Copy link
Contributor

@daniel-yavorovich daniel-yavorovich commented Dec 28, 2021

This PR adds documentation for a new PredictKube Scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#2418 & kedacore/keda#2458

@netlify
Copy link

netlify bot commented Dec 28, 2021

❌ Deploy Preview for keda failed.

🔨 Explore the source changes: 35c76b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/61f153d646e9cd0008cd5a39

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like PredictKube is a service people need an API key for. I think it would be good if:

  1. There is an introduction added before Trigger Specification clarifying that PredictKube is a service
  2. Provide transparency on the data usage that is being sent to PredictKube. This can be as simple as adding a link to a privacy/legal page on your official docs but it should provide transparency if customer metrics are used to train the model as well

Thank you!

@daniel-yavorovich
Copy link
Contributor Author

It looks like PredictKube is a service people need an API key for. I think it would be good if:

  1. There is an introduction added before Trigger Specification clarifying that PredictKube is a service
  2. Provide transparency on the data usage that is being sent to PredictKube. This can be as simple as adding a link to a privacy/legal page on your official docs but it should provide transparency if customer metrics are used to train the model as well

Thank you!

Thanks for this important point, Tom! We're currently working on our full policy to publish it in the nearest future.

@tomkerkhove
Copy link
Member

Thank you! But I'd say this is a mandatory thing to have before we can merge this feature as it is pretty important for end-users to understand.

content/docs/2.6/scalers/predictkube.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/predictkube.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/predictkube.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting for feature to be merged.

content/docs/2.6/scalers/predictkube.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/predictkube.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

@daniel-yavorovich looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

@daniel-yavorovich
Copy link
Contributor Author

looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

done, thank you

@zroubalik
Copy link
Member

looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

done, thank you

@daniel-yavorovich I can see 32 commits in this PR and majority of them non related to this PR

Signed-off-by: Daniel Yavorovych <[email protected]>
@daniel-yavorovich
Copy link
Contributor Author

looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

done, thank you

@daniel-yavorovich I can see 32 commits in this PR and majority of them non related to this PR

everything should be fine now

@tomkerkhove tomkerkhove enabled auto-merge (squash) January 26, 2022 14:16
@tomkerkhove tomkerkhove changed the title Add documentation for PredictKube scaler add PredictKube Scaler docs Jan 26, 2022
@tomkerkhove tomkerkhove merged commit 3cdd043 into kedacore:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants