Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloudwatch documentation suggesting invalid conditions #1462

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nicolajv
Copy link

Provide a description of what has been changed

The currently documentation incorrectly assumes the ability to scope down KEDA GetMetricData permissions by the use of conditions. However as shown in the official Actions defined by Amazon CloudWatch documentation, GetMetricData does not support any condition keys.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@nicolajv nicolajv requested a review from a team as a code owner August 30, 2024 11:45
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 65aacca
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67233734c5f971000878653d
😎 Deploy Preview https://deploy-preview-1462--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant