Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting setting HPA namespace variable #698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reverting setting HPA namespace variable #698

wants to merge 1 commit into from

Conversation

Rotzke
Copy link
Contributor

@Rotzke Rotzke commented Oct 25, 2024 •
edited
Loading

Sadly both metrics-server and HPA namespaces were updated in the previous MR where I added an option to use custom metrics-server namespace, this should be partially reverted since it should be required only for RoleBinding of metrics-server, not ClusterRoleBinding of HPA.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

  • Removed .Values.rbac.controlPlaneServiceAccountsNamespace variable binding for HPA ClusterRoleBinding

@Rotzke
Reverted HPA namespace variable
fa69873 
Signed-off-by: Nils Bergmüller <[email protected]>
@Rotzke Rotzke requested a review from a team as a code owner October 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rotzke