Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RBAC namespace selection for metrics server #674

Merged
merged 10 commits into from
Oct 14, 2024
Merged

Adding RBAC namespace selection for metrics server #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3fec825
Added required namespace variable and values file entry, updated docs
Rotzke Aug 5, 2024
7882190
Added required namespace variable and values file entry, updated docs
Rotzke Sep 3, 2024
fc63f00
Merge branch 'main' into feature/rbac-metrics-namespace
Rotzke Sep 3, 2024
6a3ae36
Updated helm-docs
Rotzke Sep 24, 2024
5a313ea
Updated helm-docs
Rotzke Sep 24, 2024
be80751
Updated helm-docs
Rotzke Sep 24, 2024
4013ac3
Updated helm-docs
Rotzke Sep 24, 2024
5dafe62
Updated helm-docs
Rotzke Sep 24, 2024
436627c
Updated helm-docs
Rotzke Sep 24, 2024
74552b8
Merge branch 'main' into feature/rbac-metrics-namespace
Rotzke Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions keda/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ their default values.
| `podSecurityContext` | object | [See below](#KEDA-is-secure-by-default) | [Pod security context] for all pods |
| `priorityClassName` | string | `""` | priorityClassName for all KEDA components |
| `rbac.aggregateToDefaultRoles` | bool | `false` | Specifies whether RBAC for CRDs should be [aggregated](https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles) to default roles (view, edit, admin) |
| `rbac.controlPlaneServiceAccountsNamespace` | string | `"kube-system"` | Customize the namespace of k8s metrics-server deployment This could also be achieved by the Kubernetes control plane manager flag --use-service-account-credentials: [docs](https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/) |
| `rbac.create` | bool | `true` | Specifies whether RBAC should be used |
| `rbac.enabledCustomScaledRefKinds` | bool | `true` | Whether RBAC for configured CRDs that can have a `scale` subresource should be created |
| `rbac.scaledRefKinds` | list | `[{"apiGroup":"*","kind":"*"}]` | List of custom resources that support the `scale` subresource and can be referenced by `scaledobject.spec.scaleTargetRef`. The feature needs to be also enabled by `enabledCustomScaledRefKinds`. If left empty, RBAC for `apiGroups: *` and `resources: *, */scale` will be created note: Deployments and StatefulSets are supported out of the box |
Expand Down
4 changes: 2 additions & 2 deletions keda/templates/metrics-server/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ metadata:
app.kubernetes.io/name: {{ .Values.operator.name }}-auth-reader
{{- include "keda.labels" . | indent 4 }}
name: {{ .Values.operator.name }}-auth-reader
namespace: kube-system
namespace: {{ .Values.rbac.controlPlaneServiceAccountsNamespace }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
Expand Down Expand Up @@ -59,5 +59,5 @@ roleRef:
subjects:
- kind: ServiceAccount
name: horizontal-pod-autoscaler
namespace: kube-system
namespace: {{ .Values.rbac.controlPlaneServiceAccountsNamespace }}
{{- end -}}
4 changes: 4 additions & 0 deletions keda/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ rbac:

# -- Whether RBAC for configured CRDs that can have a `scale` subresource should be created
enabledCustomScaledRefKinds: true
# -- Customize the namespace of k8s metrics-server deployment
# This could also be achieved by the Kubernetes control plane manager flag --use-service-account-credentials:
# [docs](https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/)
controlPlaneServiceAccountsNamespace: kube-system
# -- List of custom resources that support the `scale` subresource and can be referenced by `scaledobject.spec.scaleTargetRef`.
# The feature needs to be also enabled by `enabledCustomScaledRefKinds`.
# If left empty, RBAC for `apiGroups: *` and `resources: *, */scale` will be created
Expand Down
Loading