Add portName
to Operator and Webhooks for Consistency
#664
+94
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metricServer prometheus section in the KEDA chart provides a
portName
field which is the name of the port in both the deployment and the service monitor. This is not the case for the operator and admission webhooks. There's not much consistency in how the port name for the deployment is chosen vs how the service/pod monitor objects use said port.This PR unifies the interface by allowing each component to define a
portName
and makes sure that this is the name of the HTTP port being exposed in the deployment + this is the port being used by the service/service monitor/pod monitor.#647 mentions the same thing but I chose to take a different route.
This may cause a breaking change because of
serviceMonitor.port
not getting respected anymore.Checklist