fix: explicitly set insecureSkipTLSVerify as disabled for upgrades #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik
approved these changes
Sep 13, 2023
|
Is there a process to release this into the pre-2.12 charts? Lack of this patch appears to be the root cause of this issue: kedacore/keda#4732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding cert-management and removing
insecureSkipTLSVerify, it seems that during migration from the newer versions, helm doesn't remove the old value (probably because the apiservice doesn't set it explicitly).To prevent this error, this PR explicitly sets the
insecureSkipTLSVerify: false. This property can be removed in future versions once enough time has passed since we changed the value.Checklist