Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove namespace from webhook #515

Merged
merged 1 commit into from
Sep 3, 2023
Merged

remove namespace from webhook #515

merged 1 commit into from
Sep 3, 2023

Conversation

goenning
Copy link
Contributor

@goenning goenning commented Aug 31, 2023 •
edited by JorTurFer
Loading

Remove unnecessary namespace from metadata since ValidatingWebhookConfiguration is a cluster scoped resource.

Checklist

Fixes #

@goenning
remove namespace from webhook
97cc585 
Signed-off-by: Guilherme Oenning <[email protected]>
@goenning goenning requested a review from a team as a code owner August 31, 2023 09:48
JorTurFer
JorTurFer approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@JorTurFer JorTurFer enabled auto-merge (squash) September 3, 2023 19:58
@JorTurFer JorTurFer merged commit e08ac77 into kedacore:main Sep 3, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goenning @JorTurFer