Dev test fix take two #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
force-pushed
the
dev-tests-take-two
branch
from
ed934aa to
1bb905b
Compare
rosteen
force-pushed
the
dev-tests-take-two
branch
from
1bb905b to
e043085
Compare
rosteen
force-pushed
the
dev-tests-take-two
branch
from
e043085 to
d83542c
Compare
kecnry
approved these changes
Mar 28, 2024
Comment on lines
-27
to
+30
| with delay_callback(self, f'{ax}_min', f'{ax}_max'): | ||
| setattr(self, f'{ax}_min', ax_min) | ||
| setattr(self, f'{ax}_max', ax_max) | ||
| lim_helper = getattr(self, f'{ax}_lim_helper') | ||
| lim_helper.lower = ax_min | ||
| lim_helper.upper = ax_max | ||
| lim_helper.update_values() |
There was a problem hiding this comment.
would it hurt to still keep this in the delay_callback (would that still even do anything)?
|
Opening to main instead. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking into the base Glue ScatterViewer state, it looks like it uses these attribute
*_lim_helperrather than setting these values directly. Swapping out something similar here seems to fix the dev tests that were failing.