update notebooks to lcviz 0.4.2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
I'm approving with just one edit that you need before it's merged.
In the short cadence notebook, you give a data label to the stitched light curve, but try to edit the plot options on a layer that used to exist when we loaded quarters separately, causing a failure:
ValueError: HAT-P-7 Q3 not one of ['HAT-P-7', 'binned HAT-P-7:default'], reverting selection to HAT-P-7
I've made suggestions to fix this.
Should we consider putting this repo as a submodule in the lcviz repo?
| "\n", | ||
| "plot_options = lcviz.plugins['Plot Options']\n", | ||
| "plot_options.viewer = 'flux-vs-phase:default'\n", | ||
| "plot_options.layer = 'HAT-P-7'\n", | ||
| "plot_options.layer = 'HAT-P-7 Q3'\n", |
There was a problem hiding this comment.
Suggested change
| "plot_options.layer = 'HAT-P-7 Q3'\n", | |
| "plot_options.layer = 'HAT-P-7'\n", |
There was a problem hiding this comment.
hmmm are you on main or 0.4.2? I am pretty sure I ran this through and the quarter was appended to the input data-label. (0.4.x does not have spacetelescope/lcviz#120)
| "plot_options.marker_opacity = 0.1\n", | ||
| "plot_options.marker_size = 1\n", | ||
| "\n", | ||
| "plot_options.layer = 'binned HAT-P-7:default'\n", | ||
| "plot_options.layer = 'binned HAT-P-7 Q3:default'\n", |
There was a problem hiding this comment.
Suggested change
| "plot_options.layer = 'binned HAT-P-7 Q3:default'\n", | |
| "plot_options.layer = 'binned HAT-P-7:default'\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as well as some general cleanup to use public API calls, etc.