Fix “unrecognized selector sent to instance” crash in transition on iOS < 17 #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kit incorrectly marking preferredImageDynamicRange available on UIImageView since iOS 2.0
|
Hey, @ejensen. Thanks for opening this PR. Yeah, it looks like a mistake in the label. The type that it returns, |
|
@kean Sorry for closing the PR. GitHub automatically closed it when I merged a linked PR in a private repository. It is now reopened. |
|
** TEST BUILD FAILED ** on Xcode 14.3.1. I'm going to take care of it in the main branch. I think it time to drop its support because Xcode 15 has been a requirement for shipping to App Store since April. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents an “unrecognized selector sent to instance” crash caused by UIKit incorrectly marking
UIImageIVew.preferredImageDynamicRangeavailable since iOS 2.0. Its actual availability is iOS 17.0+The reference to
preferredImageDynamicRangewas added in #787 and released in Nuke v12.7.1