Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visionOS #743

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Add support for visionOS #743

merged 2 commits into from
Jan 6, 2024

Conversation

bobek-balinek
Copy link
Contributor

@bobek-balinek bobek-balinek commented Dec 25, 2023

  • Introduced a versioned Package.swift as per specification
  • Added .visionOS as a supported platform
  • Updated handling of the background mode of AVPlayer for visionOS
  • Disabled ImageDecoders.Video as AVAssetImageGenerator.copyCGImage is not available for visionOS
  • Resolves Add visionOS support #706

- Introduced a versioned Package.swift as per [specification](https://github.com/apple/swift-package-manager/blob/main/Documentation/Usage.md\#version-specific-manifest-selection)
- Added `.visionOS` as a supported platform
- Updated handling of the background mode of AVPlayer for visionOS
- Disabled `ImageDecoders.Video` as `AVAssetImageGenerator.copyCGImage` is not available for visionOS
@bobek-balinek bobek-balinek changed the title Add support for visionOS Add support for visionOS - Resolves #706 Dec 26, 2023
@bobek-balinek bobek-balinek changed the title Add support for visionOS - Resolves #706 Add support for visionOS Dec 26, 2023
@kean
Copy link
Owner

kean commented Dec 26, 2023

Hey, @bobek-balinek. Great work, thank you!
I'll test and release it shortly.

@bobek-balinek
Copy link
Contributor Author

@kean happy to have helped! Do you need me to update the CI configuration as well? I only just noticed one of the GitHub Actions has failed. I think it's sensible to switch the latest Xcode (15.1)

@kean
Copy link
Owner

kean commented Dec 27, 2023

I usually try to align with the minimum required Xcode version by the App Store, which is currently Xcode 14.1. Do you know if there is a way to keep support for the older versions?

@bobek-balinek
Copy link
Contributor Author

After some research I found a helpful article. It makes more sense to keep Package.swift at the lowest supported version of the swift toolchain, and introduce a newer specification in a "versioned" file instead.

I enabled CI on my fork to run the tests on my dime so to speak and they seem to pass without a problem.

I've also included this package in a simple visionOS Xcode project locally to ensure the Package loads and the app runs and loads images without issues.

@kean kean merged commit 37740d2 into kean:main Jan 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visionOS support
2 participants