Skip to content

Commit

Permalink
[Synthetics] Fix confusing labels for status alert toggle (elastic#16…
Browse files Browse the repository at this point in the history
…6918)

## Summary

 Fix confusing labels for status alert toggle

removed the Disabled wording from toggle 

<img width="1473" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/811cea3f-b3bd-4e65-bd48-317d259c8696">
  • Loading branch information
shahzad31 authored Sep 22, 2023
1 parent 7eb34b2 commit f5ab497
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -514,13 +514,9 @@ export const FIELD = (readOnly?: boolean): FieldMap => ({
formState.defaultValues?.[ConfigKey.MONITOR_SOURCE_TYPE] === SourceType.PROJECT;
return {
id: 'syntheticsMonitorConfigIsAlertEnabled',
label: field?.value
? i18n.translate('xpack.synthetics.monitorConfig.enabledAlerting.label', {
defaultMessage: 'Disable status alerts on this monitor',
})
: i18n.translate('xpack.synthetics.monitorConfig.disabledAlerting.label', {
defaultMessage: 'Enable status alerts on this monitor',
}),
label: i18n.translate('xpack.synthetics.monitorConfig.disabledAlerting.label', {
defaultMessage: 'Enable status alerts on this monitor',
}),
checked: field?.value || false,
onChange: async (event) => {
setValue(AlertConfigKey.STATUS_ENABLED, !!event.target.checked);
Expand All @@ -541,13 +537,9 @@ export const FIELD = (readOnly?: boolean): FieldMap => ({
formState.defaultValues?.[ConfigKey.MONITOR_SOURCE_TYPE] === SourceType.PROJECT;
return {
id: 'syntheticsMonitorConfigIsTlsAlertEnabled',
label: field?.value
? i18n.translate('xpack.synthetics.monitorConfig.edit.alertTlsEnabled.label', {
defaultMessage: 'Disable TLS alerts on this monitor.',
})
: i18n.translate('xpack.synthetics.monitorConfig.create.alertTlsEnabled.label', {
defaultMessage: 'Enable TLS alerts on this monitor.',
}),
label: i18n.translate('xpack.synthetics.monitorConfig.create.alertTlsEnabled.label', {
defaultMessage: 'Enable TLS alerts on this monitor.',
}),
checked: field?.value || false,
onChange: async (event) => {
setValue(AlertConfigKey.TLS_ENABLED, !!event.target.checked);
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -36623,10 +36623,8 @@
"xpack.synthetics.monitorConfig.clientKeyPassphrase.label": "Phrase secrète de la clé de client",
"xpack.synthetics.monitorConfig.create.alertTlsEnabled.label": "Activez les alertes TLS sur ce moniteur.",
"xpack.synthetics.monitorConfig.customTLS.label": "Utiliser la configuration TLS personnalisée",
"xpack.synthetics.monitorConfig.edit.alertTlsEnabled.label": "La désactivation arrête les alertes TLS sur ce moniteur.",
"xpack.synthetics.monitorConfig.edit.enabled.label": "Une fois désactivé, le moniteur n’exécute aucun test. Vous pouvez l’activer à tout moment.",
"xpack.synthetics.monitorConfig.enabled.label": "Activer le moniteur",
"xpack.synthetics.monitorConfig.enabledAlerting.label": "Activer les alertes de statut",
"xpack.synthetics.monitorConfig.frequency.helpText": "À quelle fréquence voulez-vous exécuter ce test ? Les fréquences les plus élevées augmenteront votre coût total.",
"xpack.synthetics.monitorConfig.frequency.label": "Fréquence",
"xpack.synthetics.monitorConfig.hostsICMP.label": "Hôte",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -36622,10 +36622,8 @@
"xpack.synthetics.monitorConfig.clientKeyPassphrase.label": "クライアントキーパスフレーズ",
"xpack.synthetics.monitorConfig.create.alertTlsEnabled.label": "このモニターでTLSアラートを有効化します。",
"xpack.synthetics.monitorConfig.customTLS.label": "カスタムTLS構成を使用",
"xpack.synthetics.monitorConfig.edit.alertTlsEnabled.label": "無効化すると、このモニターでTLSアラートを停止します。",
"xpack.synthetics.monitorConfig.edit.enabled.label": "無効化すると、モニターはテストを実行しません。いつでも有効化できます。",
"xpack.synthetics.monitorConfig.enabled.label": "モニターを有効にする",
"xpack.synthetics.monitorConfig.enabledAlerting.label": "ステータスアラートを有効にする",
"xpack.synthetics.monitorConfig.frequency.helpText": "このテストをどの程度の頻度で実行しますか?頻度が高いほど、合計コストが上がります。",
"xpack.synthetics.monitorConfig.frequency.label": "頻度",
"xpack.synthetics.monitorConfig.hostsICMP.label": "ホスト",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -36616,10 +36616,8 @@
"xpack.synthetics.monitorConfig.clientKeyPassphrase.label": "客户端密钥密码",
"xpack.synthetics.monitorConfig.create.alertTlsEnabled.label": "在此监测上启用 TLS 告警。",
"xpack.synthetics.monitorConfig.customTLS.label": "使用定制 TLS 配置",
"xpack.synthetics.monitorConfig.edit.alertTlsEnabled.label": "禁用会在此监测上停止 TLS 告警。",
"xpack.synthetics.monitorConfig.edit.enabled.label": "如果禁用,则此监测不会运行任何测试。您可以随时启用该项。",
"xpack.synthetics.monitorConfig.enabled.label": "启用监测",
"xpack.synthetics.monitorConfig.enabledAlerting.label": "启用状态告警",
"xpack.synthetics.monitorConfig.frequency.helpText": "您要多久运行此测试一次?频率越高,总成本越高。",
"xpack.synthetics.monitorConfig.frequency.label": "频率",
"xpack.synthetics.monitorConfig.hostsICMP.label": "主机",
Expand Down

0 comments on commit f5ab497

Please sign in to comment.