Remove unused imports and make other static analysis fixes

src/main/java/com/bioraft/rundeck/rancher/Errors.java

@@ -33,7 +33,6 @@ private Errors() {
 
     public enum ErrorCause implements FailureReason {
         UNSUPPORTED_OPERATING_SYSTEM,
-        UNSUPPORTED_NODE_TYPE,
         INVALID_CONFIGURATION,
         INVALID_JSON,
         IO_EXCEPTION,
@@ -48,7 +47,6 @@ public enum ErrorCause implements FailureReason {
         INTERRUPTED,
         INVALID_STACK_NAME,
         INVALID_ENVIRONMENT_NAME,
-        AUTHENTICATION_FAILURE,
         CONNECTION_FAILURE
     }
 }

src/main/java/com/bioraft/rundeck/rancher/RancherCredentials.java

@@ -9,8 +9,8 @@
 import static com.bioraft.rundeck.rancher.Constants.CONFIG_SECRETKEY_PATH;
 
 public class RancherCredentials {
-    private String accessKey;
-    private String secretKey;
+    private final String accessKey;
+    private final String secretKey;
 
     public RancherCredentials(ExecutionContext context, Map<String, String> nodeAttributes) throws IOException {
         Storage storage = new Storage(context);

src/main/java/com/bioraft/rundeck/rancher/RancherNodeExecutorPlugin.java

@@ -64,9 +64,9 @@ public class RancherNodeExecutorPlugin implements NodeExecutor, Describable {
         DESC = builder.build();
     }
 
-    private RancherWebSocketListener socketListener;
-    private RancherWebSocketListener fileCopier;
-    private Storage storage;
+    private final RancherWebSocketListener socketListener;
+    private final RancherWebSocketListener fileCopier;
+    private final Storage storage;
     private String accessKey;
     private String secretKey;
     private ExecutionListener listener;

src/test/java/com/bioraft/rundeck/rancher/HttpClientTest.java

@@ -15,7 +15,6 @@
 import java.util.Map;
 
 import static org.junit.Assert.*;
-import static org.mockito.ArgumentMatchers.any;
 import static com.bioraft.rundeck.rancher.TestHelper.*;
 import static org.mockito.Mockito.*;
 

src/test/java/com/bioraft/rundeck/rancher/RancherManageServiceTest.java

@@ -163,15 +163,13 @@ public void testPostFailure() throws IOException, NodeStepException {
     }
 
     @Test(expected = NodeStepException.class)
-    public void testNoKey() throws IOException, NodeStepException {
+    public void testNoKey() throws NodeStepException {
         cfg.put("action", "restart");
         map.remove(CONFIG_ACCESSKEY_PATH);
-//        ObjectMapper mapper = new ObjectMapper();
-
-//        String text = readFromInputStream(getResourceStream("service.json"));
-//        ObjectNode json1 = (ObjectNode) mapper.readTree(text);
-
-//        when(client.get(any())).thenReturn(json1);
+        // ObjectMapper mapper = new ObjectMapper();
+        // String text = readFromInputStream(getResourceStream("service.json"));
+        // ObjectNode json1 = (ObjectNode) mapper.readTree(text);
+        // when(client.get(any())).thenReturn(json1);
 
         try {
             RancherManageService subject = new RancherManageService(client);

src/test/java/com/bioraft/rundeck/rancher/RancherNodeExecutorPluginTest.java

@@ -23,7 +23,6 @@
 import static com.bioraft.rundeck.rancher.Constants.*;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
-import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
 
 @RunWith(MockitoJUnitRunner.class)

src/test/java/com/bioraft/rundeck/rancher/TestHelper.java

@@ -23,7 +23,7 @@ public static JsonNode resourceToJson(String resource) {
             return null;
         }
     }
-    
+
     private static String getResourceStream(String resource) {
         String path = "src/test/resources/" + resource;
         try {