Additional contexts for which the "Add to Favorites *" context menus #67
Conversation
…rites Group" context menu items appear enabled the "Add to Favorites" and "Add to Favorites Group" context menu items in additional context menus such as when right clicking an open file tab, or in the text of an open editor.
|
Thanks for the addition to the file tab; I agree that adding to open editors would be useful, you may want to check / ask at stackoverflow for the necessary API config (package.json) or API calls (would be triggered by extension activation). For the context menu in the editor: I understand that some people want everything there, but at least for me this list should be very consise; can you please split this PR to have this part separate; and maybe add a configuration there? |
Sure, I think you're right that adding a configuration setting to determine whether it appears in the editor menu is the way to go. I'll implement this when I get a chance. I'm new to VSCode extension programming and Typescript in general, so I'm still learning. |
…s will appear in via settings `favorites.includeInDocumentBodyContextMenu` : boolean (default `false`) - if set to `true`, the two "Add to * favorites" commands will be included in the editor context menu that appears when right-clicking the body of an open document. `favorites.includeInEditorTabContextMenu` : boolean (default `true`) - if set to `true`, the two "Add to * favorites" commands will be included in the context menu for the tab of a specific file (e.g. the menu that appears when right-clicking the tab of an open document).
CommanderPho
force-pushed
the
additional-context-menus
branch
from
593d59f to
3e42b5e
Compare
|
I added the suggestions proposed by @GitMensch regarding configuration options that control which context menus the "Add to * favorites" items appear in. The settings are depicted below: Let me know if there are any other changes to be made, otherwise I'd declare that this feature is mostly complete. |
There was a problem hiding this comment.
Nice work, clean and good documented and with reasonable defaults!
I really hope @kdcro101 finds some time pulling it in and do a new release.
Thanks @CommanderPho !
|
Coming back because of EclipseFdn/publish-extensions#576 - maybe it is time to recognize that @kdcro101 does not have any real activity on GithHub since quite a while... |
|
If @kdcro101 is completely inactive I'm willing to create a permanent fork to continue development, but I'm not sure what I would need to do regarding the version published on the VSCode Marketplace (and thus findable via the built-in search): https://marketplace.visualstudio.com/items?itemName=kdcro101.favorites I suppose if I were to take over the role of lead maintainer, it might be easiest in terms of discovery to name it 'Favorites V2' or something similar? I'll look into in the upcoming week and give @kdcro101 a bit more time to respond before we make any decisions, as after-all it's his idea. |
|
@CommanderPho thank you so much for the contribution. I'll publish the extension in following days. |
|
Yay!!! |
Hm, rechecking shows that the last released version is still 2.4.5 from 2018. |
Additional contexts for which the "Add to Favorites" and "Add to Favorites Group" context menu items appear
enabled the "Add to Favorites" and "Add to Favorites Group" context menu items in additional context menus such as when right clicking an open file tab, or in the text of an open editor.
#45