Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled test for PR. #119

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Mar 8, 2024

Changes:

  1. enabled test for pr
  2. Bump gh action setup-go to v4.
  3. Bump gh action checkout to v4.
  4. Fix TestUpdateReadmeAndMetadata.

Any reason to not run test for PR?

This PR include two commit, there are different thing, Or if you prefer splitting into two PRs, then I would create a separate PR for the second commit.

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

  • Email:
  • HomePage:

@liangyuanpeng
Copy link
Contributor Author

Run go test -v ./...
=== RUN   TestUpdateReadmeAndMetadata
generate artifacthub-pkg.yaml for helloworld succeed
    main_test.go:28: assertion failed: true (true bool) != false (bool)
--- FAIL: TestUpdateReadmeAndMetadata (0.[4](https://github.com/kcl-lang/modules/actions/runs/8200624251/job/22427743303?pr=119#step:5:5)4s)
=== RUN   TestCustomAhYml
generate artifacthub-pkg.yaml for helloworld succeed
    main_test.go:72: assertion failed: true (true bool) != false (bool)
--- FAIL: TestCustomAhYml (0.1[6](https://github.com/kcl-lang/modules/actions/runs/8200624251/job/22427743303?pr=119#step:5:7)s)
FAIL
FAIL	artifacthub	0.64[9](https://github.com/kcl-lang/modules/actions/runs/8200624251/job/22427743303?pr=119#step:5:10)s
FAIL
Error: Process completed with exit code 1.

@liangyuanpeng liangyuanpeng marked this pull request as draft March 11, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant