Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable read env map from KCL option("env") function #30

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

satyazzz123
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

fixes: #29

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

Read the environment var map through option("env") in KRM KCL Spec.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@satyazzz123
Copy link
Contributor Author

Hello @Peefy I have opened this PR to address issue #29 , I have made some initial changes to read env map . Please have a look and suggest if any changes are needed. Thank you!

pkg/edit/bootstrap.go Outdated Show resolved Hide resolved
pkg/edit/bootstrap.go Outdated Show resolved Hide resolved
Signed-off-by: satyazzz123 <[email protected]>
@satyazzz123
Copy link
Contributor Author

@Peefy I have addressed the requested changes please review

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9cfe827 into kcl-lang:main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Read env map from KCL option("env") function in KRM KCL Spec.
2 participants