Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more validation examples with e2e test cases #14

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 28, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1

feat: add more validation examples with e2e test cases

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • example_test.go

@Peefy Peefy force-pushed the add-more-validation-examples branch from 19ad036 to 71fa70c Compare August 28, 2023 07:40
@Peefy Peefy requested a review from He1pa August 28, 2023 07:41
@Peefy Peefy self-assigned this Aug 28, 2023
@Peefy Peefy merged commit 12cb304 into kcl-lang:main Aug 28, 2023
3 checks passed
@Peefy Peefy deleted the add-more-validation-examples branch August 28, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant