Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports add submod by ModSpec #543

Merged
merged 7 commits into from
Nov 13, 2024
Merged

feat: supports add submod by ModSpec #543

merged 7 commits into from
Nov 13, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Nov 13, 2024
@zong-zhe zong-zhe requested a review from Peefy November 13, 2024 09:44
@zong-zhe zong-zhe self-assigned this Nov 13, 2024
Signed-off-by: zongz <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11815907558

Details

  • 3 of 87 (3.45%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 42.128%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/run.go 0 1 0.0%
pkg/visitor/visitor.go 1 2 50.0%
pkg/downloader/utils.go 0 82 0.0%
Totals Coverage Status
Change from base Build 11812932471: -0.4%
Covered Lines: 4014
Relevant Lines: 9528

💛 - Coveralls

@Peefy Peefy merged commit c99c0f5 into main Nov 13, 2024
6 checks passed
@Peefy Peefy deleted the find-submod-by-spec branch November 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants