Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix downloader bug, missing cache update #493

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #478

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Sep 27, 2024
@zong-zhe zong-zhe requested a review from Peefy September 27, 2024 07:46
@zong-zhe zong-zhe self-assigned this Sep 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11066647634

Details

  • 0 of 29 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 41.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/downloader/downloader.go 0 9 0.0%
pkg/utils/utils.go 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/downloader/downloader.go 1 36.21%
Totals Coverage Status
Change from base Build 11048517978: -0.04%
Covered Lines: 3469
Relevant Lines: 8404

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1422034 into kcl-lang:main Sep 27, 2024
4 of 6 checks passed
Copy link

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
4 participants