-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jay reich sprint1 #91
Open
BlueJayBird11
wants to merge
41
commits into
kcherr1:main
Choose a base branch
from
BlueJayBird11:JayReich_Sprint1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a line from a test
…03_Project Adding DialogueBox class and pulling
Created as test file
Create Ethan-Test-File.txt
…toggle key using 'x', slight glitch in how the box looks
In this commit a class was created (AudioManager.cs), adding multiple files to the project in the data section as well as registering them as resources (Resources.resx) not completely finished with the user story here are the list of thing yet to be fixed/done. - find a way to play audio files sequentially. - need to find a way to stop battle/start overworld music if the end user exits the fight via X button - finish documentation regarding how to add audio file to the game - comments
Now starts the battle after the dialogue finishes. Current bug - The system is trying to open the dialogue box multiple times, causing an index error and crash.
Added Overworld and battle music
Added health bar to main screen
Added Dialogue for Poison Koolaid and Cheeto, and fixed bug where the dialogue box was being called multiple times. Has caused another bug to arise where you can't initiate a battle twice.
Added a few comments
Removed an unnecessary check from an if statement
Increased from 11.25 to 16
Fixed bug when clicking on label itself in dialogue box. Can now continue the dialogue with the space bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User story:
"As a user, I see dialogue before fighting an enemy."
Bug - The dialogue box image wants to stretch despite appearing correctly in the editor.