-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jquery.svgdom fixes for jquery 1.8.3 #8
base: master
Are you sure you want to change the base?
Conversation
+1 |
It would be also great to have a bunch of unit tests to ensure, that fixes works correctly in all expected situations. I have used the jquery test suite to ensure that jquery core is not affected by the overrides of jquery.svgdom plugin. The functionality of jquery.svgdom could only be tested through our application, but it uses only a few features of the jquery.svg plugin. |
Hey hey, man. Very thanks. |
+1 |
tested with jquery 1.9.0, still good. thanks! one catch, but I'm not sure if that is in your patch or somewhere else in svgdom - in explorer7, jquery itself seemed to 'break without errors' - a lot of selectors werent working anymore. explorer8 was still fine. since it wont work in ie<9 anyway, i'm including the scripts within (yuk) IE conditional comments. |
Hmm, does not work for me with jquery 1.9.1 since there is no $.browser anymore... (but here I am talking about jquery.svg.js and not jquery.svgdom.js, my bad) I'll fork the project and try to fix it... Hmmm, this problem is already mentioned in issue #9 so I'll continue over there! |
Applied pull request kbwood#8 by micha149
I have fixed a lot of issues with the current jquery version 1.8.3 which occured in my project. This should also fix the most problems from issue #5
Created a minified version with yui compressor, but this file was not tested!