python3 fixes for tracer.py iteritems, Readme

README.rst

@@ -31,11 +31,11 @@ In order to implement tracing in your system, add the following lines of code to
 
     # if not included, defaults to False
     # has to come before OPENTRACING_TRACER setting because python...
-    OPENTRACING_TRACE_ALL = False, 
+    OPENTRACING_TRACE_ALL = False
 
     # defaults to []
     # only valid if OPENTRACING_TRACE_ALL == True
-    OPENTRACING_TRACED_ATTRIBUTES = ['arg1', 'arg2'],
+    OPENTRACING_TRACED_ATTRIBUTES = ['arg1', 'arg2']
 
     # Callable that returns an `opentracing.Tracer` implementation.
     OPENTRACING_TRACER_CALLABLE = 'opentracing.Tracer'
@@ -50,7 +50,7 @@ If you want to directly override the `DjangoTracer` used, you can use the follow
 .. code-block:: python
 
     # some_opentracing_tracer can be any valid OpenTracing tracer implementation
-    OPENTRACING_TRACER = django_opentracing.DjangoTracer(some_opentracing_tracer), 
+    OPENTRACING_TRACER = django_opentracing.DjangoTracer(some_opentracing_tracer)
 
 **Note:** Valid request attributes to trace are listed [here](https://docs.djangoproject.com/en/1.9/ref/request-response/#django.http.HttpRequest). When you trace an attribute, this means that created spans will have tags with the attribute name and the request's value.
 
@@ -101,14 +101,15 @@ Tracing an RPC
 If you want to make an RPC and continue an existing trace, you can inject the current span into the RPC. For example, if making an http request, the following code will continue your trace across the wire:
 
 .. code-block:: python
+    from future.utils import listitems # for python3 compatibility
 
     @tracer.trace()
     def some_view_func(request):
         new_request = some_http_request
         current_span = tracer.get_span(request)
         text_carrier = {}
         opentracing_tracer.inject(span, opentracing.Format.TEXT_MAP, text_carrier)
-        for k, v in text_carrier.iteritems():
+        for k, v in listitems(text_carrier):
             request.add_header(k,v)
         ... # make request
 

django_opentracing/tracer.py

@@ -1,5 +1,6 @@
 from django.conf import settings
 from django.utils.module_loading import import_string
+from future.utils import listitems
 import opentracing
 import threading
 
@@ -64,7 +65,7 @@ def _apply_tracing(self, request, view_func, attributes):
         '''
         # strip headers for trace info
         headers = {}
-        for k,v in request.META.iteritems():
+        for k,v in listitems(request.META):
             k = k.lower().replace('_','-')
             if k.startswith('http-'):
                 k = k[5:]

example/client/views.py

@@ -1,6 +1,7 @@
 from django.conf import settings
 from django.http import HttpResponse
 from django.shortcuts import render
+from future.utils import listitems
 
 import opentracing
 import urllib2
@@ -51,6 +52,6 @@ def client_child_span(request):
 def inject_as_headers(tracer, span, request):
     text_carrier = {}
     tracer._tracer.inject(span.context, opentracing.Format.TEXT_MAP, text_carrier)
-    for k, v in text_carrier.iteritems():
+    for k, v in listitmes(text_carrier):
         request.add_header(k,v)