Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_host_name method #75

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Add get_host_name method #75

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f623915
Add get_host_name method
Oct 24, 2020
6bd3e27
shortend get_host_name
Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fritzconnection/lib/fritzhosts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,19 @@ def set_host_name(self, mac_address, name):
}
self._action('X_AVM-DE_SetHostNameByMACAddress', arguments=args)

def get_host_name(self, mac_address):
"""
Returns a String with the host_name of the device with the given mac_address
"""
host = list
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not necessary. It just binds the list callable to a new label never used later on.

try:
host = self.get_specific_host_entry(mac_address)
except:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please never use a 'naked' except, because it will be hard to find bugs later on. Explicitly catch just the error types you expect and are able to handle.

host = {
'NewHostName': 'Error' # fix this problem --> if the router mac is transferd i got an error with specific host entry method
}
return host['NewHostName']

def run_host_update(self, mac_address):
"""
Triggers the host with the given `mac_address` to run a system
Expand Down